Skip to content

sqlite: add sqlite prepare options args #61311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
araujogui wants to merge 5 commits into
base: main
Choose a base branch
from
Open

sqlite: add sqlite prepare options args #61311

araujogui wants to merge 5 commits into from
+457 −1

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Jan 8, 2026

Fixes #61235

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 8, 2026

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 8, 2026
@araujogui araujogui force-pushed the sqlite-prepare-options branch 2 times, most recently from b62c50e to 9bca95a Compare January 8, 2026 01:51
@codecov
Copy link

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.81013% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (903f647) to head (9418cab).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 84.81% 7 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61311      +/-   ##
==========================================
- Coverage   88.54%   88.51%   -0.03%     
==========================================
  Files         704      704              
  Lines      208793   208872      +79     
  Branches    40307    40336      +29     
==========================================
+ Hits       184866   184879      +13     
- Misses      15913    15965      +52     
- Partials     8014     8028      +14
Files with missing lines Coverage Δ
src/node_sqlite.h 80.39% <ø> (ø)
src/node_sqlite.cc 80.32% <84.81%> (+0.15%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

This comment was marked as outdated.

Sign in to view

@araujogui araujogui force-pushed the sqlite-prepare-options branch from bb33e58 to 6da81dd Compare January 8, 2026 20:30
@araujogui araujogui requested a review from Renegade334 January 8, 2026 20:31
@araujogui araujogui force-pushed the sqlite-prepare-options branch from 45a8e19 to faaec9f Compare January 8, 2026 23:03
mcollina
mcollina approved these changes Jan 11, 2026
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 11, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70778/

@Renegade334 Renegade334 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 11, 2026
gurgunday
gurgunday approved these changes Jan 11, 2026
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ovflowd
ovflowd reviewed Jan 14, 2026
View reviewed changes
@araujogui araujogui force-pushed the sqlite-prepare-options branch from faaec9f to 9418cab Compare January 14, 2026 14:35
ovflowd
ovflowd approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@ovflowd ovflowd added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. semver-minor PRs that contain new features and should be released in the next minor version. labels Jan 15, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2026

Commit Queue failed
- Loading data for nodejs/node/pull/61311
✔  Done loading data for nodejs/node/pull/61311
----------------------------------- PR info ------------------------------------
Title      sqlite: add sqlite prepare options args (#61311)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     araujogui:sqlite-prepare-options -> nodejs:main
Labels     c++, semver-minor, author ready, needs-ci, commit-queue-squash, sqlite
Commits    5
 - sqlite: add sqlite prepare options args
 - sqlite: validate options before creating stmt
 - sqlite: revert set methods
 - sqlite: create options test cases
 - sqlite: add prepare options doc
Committers 1
 - Guilherme Araújo <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61311
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61311
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: René <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 08 Jan 2026 01:44:47 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648468628
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648497153
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/61311#pullrequestreview-3648737731
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/61311#pullrequestreview-3663415516
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-11T20:40:21Z: https://ci.nodejs.org/job/node-test-pull-request/70778/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - sqlite: add sqlite prepare options args
   ⚠  - sqlite: validate options before creating stmt
   ⚠  - sqlite: revert set methods
   ⚠  - sqlite: create options test cases
   ⚠  - sqlite: add prepare options doc
- Querying data for job/node-test-pull-request/70778/
✔  Build data downloaded
- Querying failures of job/node-test-commit/84751/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/21030184729

@ovflowd
Copy link
Member

ovflowd commented Jan 15, 2026

cc @araujogui can you add an e-mail on your public profile? I also didn't see that CI didn't run for the rebase, let me trigger it.

@ovflowd ovflowd added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 15, 2026
@ovflowd
Copy link
Member

ovflowd commented Jan 15, 2026

fyi, I'm marking this as semver-minor, just because it changes API of an existing method, even if it is a new property. Just to be on the safe-side of things.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 15, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70810/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@ovflowd ovflowd ovflowd approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite: db.prepare(sql, options)

6 participants

@araujogui @nodejs-github-bot @ovflowd @mcollina @Renegade334 @gurgunday